• Blackthorn@programming.dev
    link
    fedilink
    English
    arrow-up
    4
    ·
    1 year ago

    Oh man, I hate code reviews with the strength of a thousand suns. In the enterprise world, there are so many constraints and conventions that reading other people code is even more boring than it should be. It’s even worse when you LGTM it and your colleagues “accuse” you of not having read it with attention because “I can’t believe you don’t have any comment on my code”.

    • ???@lemmy.world
      link
      fedilink
      English
      arrow-up
      2
      ·
      edit-2
      1 year ago

      Well, if you don’t even have any comments at all, neither good nor bad, then “LGTM” doesn’t ever really translate to "I have read all your code and it’s wonderfule/okay enough to pass"

      To me, having worked as a developer for some years now, it means “don’t got no time to look into your codes, so here’s a stamp of approval to send you along your way, knowing too well that you expected me to look into your code but I didn’t”

      My point being, if you want to say you read all the code and it’s fine, maybe refrain from using “LGTM”, which is the universal sign of malicious compliance/not caring.