Update: The original dev does not remember exactly. However they have said that clientId was originally a VARCHAR, so this may have been checking for both '0' or ''

So an over-engineered workaround to a bad datatype perhaps?

I forgot to mention this is in SQL Server, so SIN operates on radians. So I THINK this can only ever cast to a 0 when clientId is also 0

It certainly doesn’t for any of the 100,000 existing rows

The client table has around 100,000 rows each with a unique clientId, none of which are returned from the CAST / ABS / SIN

I think you are right and this is a ‘fix’ for something lost to time. I am going to talk to the original dev tomorrow to see if they remember what it was for

Thank you so much, I’ll check it out!

Absolutely, it’s a great read. Could you link the video you watched?

1. Soft Skills Engineering - Software engineering advice podcast
2. If Books Could Kill - Criticising reviews of bestselling books
3. CoRecursive - Stories about software